[patch] [libcxx] chrono.cpp revision

[Yaron Keren]

Warn at compile time and abort at runtime is indeed the best solution to
disabled functionality, as it enables compiling programs which may need
chrono for some auxilary function but will otherwise function, while
warning that's what going to happen.

However, disabled funcitonality is not very good. Visual C++ 2012, 2013
does provide chrono functionality, as does libstdcxx. We should not be
behind: when libcxx is built with Visual C++ it may use the #include
<thr/xtimec.h> non-standard functions in the same way (but not identical
code, of course) Visual C++ own chrono uses them.

Yaron



2013/10/7 G M <gmisocpp at gmail.com>

> Hi Howard
>
> Attached is a slight revision to my earlier chrono.cpp patch to fix a
> mistake.
>
> Yaron, this patch is intended to warn at compile time and abort with a
> message at runtime. I got the impression you might not have realised that
> before. Do you have any objection to this patch?
>
> Reid are you still LGTM with this?
>
> I might submit a basic implementation for these functions in the not to
> distant future but truly accurate and fast versions are more complicated
> than they look from what I can tell.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131007/aa8c8612/attachment.html>