[libcxx] r192080 - Apparently,	I don't know the difference between 'left' and 'right'. Swap parameters	named 'lhs' and 'rhs' so that they correctly refer to the 'left hand	side'	and 'right hand side' of comparisons. No functionality change. Thanks	to Arthur O'Dwyer for pointing this out to me.
    Marshall Clow 
    mclow.lists at gmail.com
       
    Sun Oct  6 19:37:18 PDT 2013
    
    
  
Author: marshall
Date: Sun Oct  6 21:37:18 2013
New Revision: 192080
URL: http://llvm.org/viewvc/llvm-project?rev=192080&view=rev
Log:
Apparently, I don't know the difference between 'left' and 'right'. Swap parameters named 'lhs' and 'rhs' so that they correctly refer to the 'left hand side' and 'right hand side' of comparisons. No functionality change. Thanks to Arthur O'Dwyer for pointing this out to me.
Modified:
    libcxx/trunk/test/utilities/optional/optional.comp_with_t/equal.pass.cpp
    libcxx/trunk/test/utilities/optional/optional.comp_with_t/less_than.pass.cpp
    libcxx/trunk/test/utilities/optional/optional.relops/equal.pass.cpp
    libcxx/trunk/test/utilities/optional/optional.relops/less_than.pass.cpp
Modified: libcxx/trunk/test/utilities/optional/optional.comp_with_t/equal.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/utilities/optional/optional.comp_with_t/equal.pass.cpp?rev=192080&r1=192079&r2=192080&view=diff
==============================================================================
--- libcxx/trunk/test/utilities/optional/optional.comp_with_t/equal.pass.cpp (original)
+++ libcxx/trunk/test/utilities/optional/optional.comp_with_t/equal.pass.cpp Sun Oct  6 21:37:18 2013
@@ -23,8 +23,8 @@ struct X
     constexpr X(int i) : i_(i) {}
 };
 
-constexpr bool operator == ( const X &rhs, const X &lhs )
-    { return rhs.i_ == lhs.i_ ; }
+constexpr bool operator == ( const X &lhs, const X &rhs )
+    { return lhs.i_ == rhs.i_ ; }
     
 #endif
 
Modified: libcxx/trunk/test/utilities/optional/optional.comp_with_t/less_than.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/utilities/optional/optional.comp_with_t/less_than.pass.cpp?rev=192080&r1=192079&r2=192080&view=diff
==============================================================================
--- libcxx/trunk/test/utilities/optional/optional.comp_with_t/less_than.pass.cpp (original)
+++ libcxx/trunk/test/utilities/optional/optional.comp_with_t/less_than.pass.cpp Sun Oct  6 21:37:18 2013
@@ -23,8 +23,8 @@ struct X
     constexpr X(int i) : i_(i) {}
 };
 
-constexpr bool operator < ( const X &rhs, const X &lhs )
-    { return rhs.i_ < lhs.i_ ; }
+constexpr bool operator < ( const X &lhs, const X &rhs )
+    { return lhs.i_ < rhs.i_ ; }
     
 #endif
 
Modified: libcxx/trunk/test/utilities/optional/optional.relops/equal.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/utilities/optional/optional.relops/equal.pass.cpp?rev=192080&r1=192079&r2=192080&view=diff
==============================================================================
--- libcxx/trunk/test/utilities/optional/optional.relops/equal.pass.cpp (original)
+++ libcxx/trunk/test/utilities/optional/optional.relops/equal.pass.cpp Sun Oct  6 21:37:18 2013
@@ -24,8 +24,8 @@ struct X
     constexpr X(int i) : i_(i) {}
 };
 
-constexpr bool operator == ( const X &rhs, const X &lhs )
-    { return rhs.i_ == lhs.i_ ; }
+constexpr bool operator == ( const X &lhs, const X &rhs )
+    { return lhs.i_ == rhs.i_ ; }
     
 #endif
 
Modified: libcxx/trunk/test/utilities/optional/optional.relops/less_than.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/utilities/optional/optional.relops/less_than.pass.cpp?rev=192080&r1=192079&r2=192080&view=diff
==============================================================================
--- libcxx/trunk/test/utilities/optional/optional.relops/less_than.pass.cpp (original)
+++ libcxx/trunk/test/utilities/optional/optional.relops/less_than.pass.cpp Sun Oct  6 21:37:18 2013
@@ -22,8 +22,8 @@ struct X
     constexpr X(int i) : i_(i) {}
 };
 
-constexpr bool operator < ( const X &rhs, const X &lhs )
-    { return rhs.i_ < lhs.i_ ; }
+constexpr bool operator < ( const X &lhs, const X &rhs )
+    { return lhs.i_ < rhs.i_ ; }
 
 #endif
 
    
    
More information about the cfe-commits
mailing list