[PATCH] Refactor DynTypedMatcher into a value type class, just like Matcher<T>.
Manuel Klimek
klimek at google.com
Sat Oct 5 01:46:15 PDT 2013
================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:526
@@ +525,3 @@
+ StorageType Storage;
+};
+
----------------
I have to cringe when I look at that implementation. I most definitely would hope to never have to touch it.
It's very complex and hard to understand, and I don't see the big benefits apart from having a workaround for a VSC++ bug.
http://llvm-reviews.chandlerc.com/D1661
More information about the cfe-commits
mailing list