[PATCH][StaticAnalyser] Replace magic strings for bug category with constant

Jordan Rose jordan_rose at apple.com
Thu Oct 3 10:01:02 PDT 2013


Thanks, Daniel! Committed in r191910.

Jordan

On Oct 2, 2013, at 11:27 , Daniel Marjamäki <Daniel.Marjamaki at evidente.se> wrote:

> Hello!
> 
> Based on previous reviews on other patches I created this patch.
> 
> This replaces magic strings for bug categories with constants.
> 
> As far as I see all tests runs fine (if the string categories::LogicError is replaced to anything other than "Logic error" there are assertions).
> 
> There is a minor change in behaviour. In CheckSizeofPointer.cpp the bug category is changed from "Logic" to "Logic error". Other than this.. there should be no change in behaviour anywhere.
> 
> Best regards,
> Daniel Marjamäki
> 
> ..................................................................................................................
> Daniel Marjamäki Senior Engineer
> Evidente ES East AB  Warfvinges väg 34  SE-112 51 Stockholm  Sweden
> 
> Mobile:                 +46 (0)709 12 42 62
> E-mail:                 Daniel.Marjamaki at evidente.se
> 
> www.evidente.se
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commonbugcategories.diff
Type: text/x-patch
Size: 4229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131003/b27e70bb/attachment.bin>
-------------- next part --------------
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list