[PATCH] [ms-cxxabi] Fix the calling convention for operator new in records

Eli Friedman eli.friedman at gmail.com
Mon Sep 30 15:03:35 PDT 2013


  Would it make sense to define Declarator::isMember(), which checks `getContext() == MemberContext && DS.getStorageClassSpec() != DeclSpec::SCS_typedef && !DS.isFriendSpecified()` or something like that?

  Also, should isStaticMember() check `DS.getStorageClassSpec() != DeclSpec::SCS_typedef && !DS.isFriendSpecified()`?

  Sorry for going through so many review cycles on this; it's sort of confusing stuff, so I want it to be as easy to read as possible.

http://llvm-reviews.chandlerc.com/D1761



More information about the cfe-commits mailing list