[PATCH] Implements Parts of Intrin.h

Eric Christopher echristo at gmail.com
Fri Sep 27 12:08:18 PDT 2013

Comment at: lib/Headers/Intrin.h:349
@@ +348,3 @@
+static __inline__ unsigned char __attribute__((__always_inline__, __nodebug__))
+_rotl8(unsigned char _Value, unsigned char _Shift) {
Reid Kleckner wrote:
> This file by itself shouldn't first declare these non-static and then make then static, inline, always_inline.  You may want to combine the decl and definition.

Comment at: lib/Headers/Intrin.h:366
@@ -316,3 +365,3 @@
 short _InterlockedOr16_np(short volatile *_Value, short _Mask);
-__int64 _InterlockedOr64_np(__int64 volatile *_Value, _int64 _Mask);
+__int64 _InterlockedOr64_np(__int64 volatile *_Value, __int64 _Mask);
 char _InterlockedOr8_np(char volatile *_Value, char _Mask);
Commit this separately as a bugfix.


More information about the cfe-commits mailing list