[PATCH] [PATCH] OpenMP firstprivate clause

Doug Gregor dgregor at apple.com
Fri Sep 27 11:54:09 PDT 2013


  Some minor cleanup comments, but otherwise this LGTM.


================
Comment at: lib/Sema/SemaOpenMP.cpp:987
@@ +986,3 @@
+    //  class type.
+    while (Type.getNonReferenceType()->isArrayType()) {
+      Type = cast<ArrayType>(
----------------
ASTContext::getBaseElementType() does this loop for you. Please use that.

================
Comment at: lib/Sema/SemaOpenMP.cpp:1038
@@ +1037,3 @@
+      bool IsConstant = Type.isConstant(Context);
+      while (Type->isArrayType()) {
+        QualType ElemType =
----------------
ASTContext::getBaseElementType() again.


http://llvm-reviews.chandlerc.com/D1694



More information about the cfe-commits mailing list