r191523 - Abstract out the emission of vtables, add basic support for vtable emission when using -cxx-abi microsoft

Timur Iskhodzhanov timurrrr at google.com
Fri Sep 27 10:11:41 PDT 2013


r191534.
Really sorry for breaking stuff!

You can see I actually took time to define a THIS variable, just
forgot to use it on the next line
:-X

2013/9/27 Timur Iskhodzhanov <timurrrr at google.com>:
> No worries, I were able to repro, even on Linux.
> Working on a fix
>
> 2013/9/27 jahanian <fjahanian at apple.com>:
>>
>> On Sep 27, 2013, at 9:50 AM, Charles Davis <cdavis5x at gmail.com> wrote:
>>
>>
>> On Sep 27, 2013, at 10:40 AM, jahanian wrote:
>>
>>
>> On Sep 27, 2013, at 8:53 AM, jahanian <fjahanian at apple.com> wrote:
>>
>> This patch causes a test failure in a win64 buildbot.
>>
>> C:\public\win64\src\tools\clang\test\CodeGenCXX\microsoft-abi-multiple-nonvirtual-inheritance.cpp:165:12:
>> error: expected string not found in input
>>    // CHECK: %[[VFPTR:.*]] = bitcast %struct.ChildOverride* %this1 to [1 x
>> i8*]**
>>
>>
>> [[THIS]]
>>
>> He's trying to tell you that it won't have that name outside of a +Asserts
>> build, so you need to use a FileCheck variable to match the name of the this
>> pointer value.
>>
>>
>> Oops yes. Email was sent out prematurely sorry.  This is a suspect. But it
>> does not work for me on my machine for some reason.
>>
>> - Fariborz
>>
>>



More information about the cfe-commits mailing list