r191486 - Add -fno-unsigned-char and ignore it. We already support -fno-signed-char, add

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Sep 27 06:49:10 PDT 2013

> Should we really be ignoring this? I would have thought we should look for
> the last of -fsigned-char, -fno-unsigned-char, -funsigned-char,
> -fno-signed-char, and pick a signed type unless the last flag (if any) is
> one of the latter two.
> For instance, -funsigned-char -fno-unsigned-char should probably leave char
> signed.

That is what gcc does. With the command

gcc -Wall -std=c++11 test.cpp -S -funsigned-char -fno-unsigned-char

gcc compiles

#include <type_traits>
static_assert(std::is_signed<char>::value, "foo");


More information about the cfe-commits mailing list