[PATCH] Added callback support for OpenCL extension pragmas.
mikael.lepisto at vincit.fi
Fri Sep 27 00:35:48 PDT 2013
Hi, I submitted this patch ~20 days ago. Could this get some
comments/review if the solution is acceptable or if there is some other
preferred way to implement it?
On Mon, Sep 16, 2013 at 8:37 AM, Mikael Lepistö <mikael.lepisto at vincit.fi>wrote:
> Hi, ping
> I sent this simple patch some time ago to list, but it got no responses.
> Is there any estimates, when this might be reviewed or added to main repo?
> Thanks, Mikael Lepistö
> I also added missing [PATCH] tag to subject (I forgot to to put it to
> original mail).
> On Sat, Sep 7, 2013 at 12:49 PM, Mikael Lepistö <mikael.lepisto at vincit.fi>wrote:
>> We needed in our project (https://github.com/KhronosGroup/webcl-validator)
>> to be able to define callbacks for handling OpenCL extension pragmas to
>> catch easily which OpenCL extensions are enabled/disabled.
>> I attached the patch file and test case for the functionality. Rami
>> Ylimäki is actually author of the implementation I just wrote the test case
>> and cleaned up the patch for upstreaming.
>> I had to add clangParse and clangSema libraries to PPCallbacksTest
>> compilation, because enabling OpenCL support for preprocessor required
>> Parser instance. Parser instance actually reads LangOptions from
>> preprocessor and registers correct pragma handlers to preprocessor.
>> Any comments, improvements?
>> Cheers, Mikael Lepistö
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits