[patch] Slightly less hackish implementation of -Wwrite-strings

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Sep 25 14:44:42 PDT 2013


With this patch -Wwrite-strings is still implemented with the terrible
hack of passing -fconst-strings to -cc1, but at least the driver uses
the regular warning checking code path.

Since we don't support a warning that is DefaultIgnore in one language
but not in another, this patch
creates a dummy C only warning in the same group as the existing one
to get the desired effect.

Chandler, is the include of clang/Sema/SemaDiagnostic.h OK in here or
some extra refactoring is needed?

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 4015 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130925/f1031901/attachment.obj>


More information about the cfe-commits mailing list