r189535 - Add missing definitions to unwind.h.

[Hans Wennborg]

On Wed, Sep 25, 2013 at 7:24 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
>> The problem is that if we use _Unwind_GetIP from unwind.h, we fail to
>> link because the symbol is not defined in libgcc on Android.
>>
>> It seems that libgcc provides inline definitions of these functions
>> (it uses macros actually), so maybe that's what we should do? I've
>> attached a patch, but would need someone more experienced to look at
>> it since I'm not familiar with these functions.
>
> Yes, it looks like we have to do something equivalent to what the gcc one does.
>
> Just two comments:
>
> * _Unwind_GetIPInfo is the same in both #ifdef branches, just keep it out of it.

Done.

> * Can you check if darwin arm has declarations or definitions? If
> declarations, we should probably also only have declarations in that
> case.

Darwin's /usr/include/unwind.h on my Mac only provides declarations of
these functions, irrespective of architecture.

So, should we do something like the new patch attached?

Thanks,
Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unwind_h.patch
Type: application/octet-stream
Size: 1898 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130925/2d2336ec/attachment.obj>