[patch] [libcxx] inline consistency

G M gmisocpp at gmail.com
Mon Sep 23 07:20:27 PDT 2013


Hi Everyone

Attached is a patch that changes all references to "x inline" to "inline x"
where x = _libcpp_always_inline or _libcpp_inline_visibility macros.

The patch touches these files:
locale
array
deque
new
string
utility
vector
__bit_reference
__split_buffer
locale_win32.h

There is no intended functionality change and it is expected that reversing
the position of the inline keyword with regard to the other keywords does
not change the meaning of anything, least not for apple/Linux etc.

It is intended to make libcxx more consistent with itself and to prevent
the 1000 or so
"inline.cpp(3) : warning C4141: 'inline' : used more than once" warnings
that MS's cl.exe compiler emits without this patch, i.e. if inline is not
the first keyword before a function name etc.

Prefer "inline [other inline related keyword]" over "[other related
keyword] inline".
After this patch, libcxx should be consistent to this pattern.

Thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130924/c97a0a96/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inline_x.diff
Type: application/octet-stream
Size: 52157 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130924/c97a0a96/attachment.obj>


More information about the cfe-commits mailing list