[PATCH] [ARM] Remove dead code for target architectures with a '-' in the name
bradley.smith at arm.com
Thu Sep 19 03:14:54 PDT 2013
> -----Original Message-----
> From: Bob Wilson [mailto:bob.wilson at apple.com]
> Sent: 18 September 2013 01:57
> To: reviews+D1695+public+417e6477d2f7df9d at llvm-reviews.chandlerc.com
> Cc: Bradley Smith; cfe-commits at cs.uiuc.edu
> Subject: Re: [PATCH] [ARM] Remove dead code for target architectures
> with a '-' in the name
> I looked at this very briefly. I don't think the hyphenated
> architecture names get used much, but we shouldn't break them without a
> compelling reason. Brad, your patch seems to be based on the
> assumption that the architecture name will be coming from the triple.
> That is one possibility, but it can also come from the -march option.
> You are right that the hyphenated names won't work in triples, but they
> work fine with -march.
Ah yes you're completely right, I hadn't realised that these could also be
used for -march. Disregard this patch for now, it might be nice to do
something to improve this area in the future, but I think that will require
some more significant re-engineering. Thanks.
More information about the cfe-commits