[PATCH] [-cxx-abi microsoft] Correctly identify Win32 entry points

Reid Kleckner rnk at google.com
Mon Sep 16 10:29:36 PDT 2013


  Thanks, LGTM!


================
Comment at: lib/Sema/SemaDecl.cpp:7694-7696
@@ +7693,5 @@
+      FT->getResultType()->isNullPtrType())
+    // DllMain is exempt because a return value of zero means it failed.
+    if (FD->getName() != "DllMain")
+      FD->setHasImplicitReturnZero(true);
+
----------------
I'd cover these in braces, since it's no longer a single line.


http://llvm-reviews.chandlerc.com/D1683

BRANCH
  UDE

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list