[PATCH] Lex and ignore Microsoft's #pragma warning(...)

Richard Smith richard at metafoo.co.uk
Fri Sep 13 13:28:22 PDT 2013


LGTM

On Fri, Sep 13, 2013 at 11:26 AM, Reid Kleckner <rnk at google.com> wrote:

> ================
> Comment at: lib/Lex/Pragma.cpp:1106
> @@ +1105,3 @@
> +        // Collect the warning ids.
> +        SmallVector<int, 1> Ids;
> +        PP.Lex(Tok);
> ----------------
> Richard Smith wrote:
> > Only 1 inline ID? Cheapskate! =) Maybe 10? 16?
> These are usually issued one by one.  :)


IIRC I've written code which had about 5 or 6 warning numbers listed in a
single pragma. But whatever you prefer, this is never going to matter in
practice.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130913/c625b065/attachment.html>


More information about the cfe-commits mailing list