[PATCH] Add error checking to reject neon_vector_type attribute on targets without NEON

[Artyom Skrobov]

Bernie, you're right, my fault for posting this in the wrong place.

Reposting to cfe-commits.


-----Original Message-----
From: Bernard Ogden
Sent: 13 September 2013 11:02
To: Artyom Skrobov; llvm-commits at cs.uiuc.edu
Subject: RE: [PATCH] Add error checking to reject neon_vector_type attribute on targets without NEON

Hi Artyom,

LGTM - but I think you should have posted this one on cfe-commits.

The removal of the "sophisticated string parsing" gave me some pause as I
think that architecturally-illegal feature combinations should result in a
warning, at a minimum - but I'm fairly sure that other illegal combinations
are permitted and this specific check is clearly broken, so discarding it
seems the pragmatic thing to do.

Regards,

Bernie

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Artyom Skrobov
> Sent: 12 September 2013 17:17
> To: llvm-commits at cs.uiuc.edu
> Subject: [PATCH] Add error checking to reject neon_vector_type
> attribute on targets without NEON
>
> Hello,
>
> We have discovered that test/Sema/neon-vector-types.c did not specify a
> target, therefore testing the NEON-related attributes on the host
> platform (which, in many cases, wouldn't even be ARM!)
>
> In addition to correcting this oversight in the test, we're adding a
> check that the NEON-related attributes aren't used on a target without
> NEON.
>
> We're also removing the sophisticated string parsing from
> ARMTargetInfo::hasFeature, on the grounds that it's 1) broken in cases
> when target CPU name is not specified explicitly; 2) outdated by
> disregarding ARMv8; 3) clearly in the wrong place -- analysing target
> CPU capabilities belongs in ARMTargetInfo initialisation, but needs not
> re-run every time a NEON-related feature is used.
>
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy
> the information in any medium.  Thank you.
>
> ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ,
> Registered in England & Wales, Company No:  2557590
> ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1
> 9NJ, Registered in England & Wales, Company No:  2548782



-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2548782