[PATCH] [-cxx-abi microsoft] Mangle declarations inside extern "C"

David Majnemer david.majnemer at gmail.com
Fri Sep 13 01:58:27 PDT 2013



================
Comment at: lib/AST/MicrosoftMangle.cpp:312
@@ -270,7 +311,3 @@
   FD = FD->getFirstDeclaration();
 
   // We should never ever see a FunctionNoProtoType at this point.
----------------
Timur Iskhodzhanov wrote:
> Why can't we just
> 
>   if (!Context.shouldMangleDeclName(FD)) {
>     Out << '9';
>     return
>   }
> 
> here?
Because things will eventually get more complicated later. Extern-c functions as template arguments show this off "nicely"


http://llvm-reviews.chandlerc.com/D1655



More information about the cfe-commits mailing list