[PATCH] Refactor Compilation::PrintJob and PrintDiagnosticJob into Job::Print

Hans Wennborg hans at chromium.org
Thu Sep 12 11:26:08 PDT 2013

Comment at: lib/Driver/Driver.cpp:444
@@ -443,3 +443,3 @@
   if (FailingCommand)
-    C.PrintDiagnosticJob(OS, *FailingCommand);
+    FailingCommand->Print(OS, "\n", /*Quote*/ false, /*CrashReportFlagsOnly*/ true);
Reid Kleckner wrote:
> This is 84 cols?  Also, you named the bool "CrashReport", not "CrashReportFlagsOnly".

Comment at: lib/Driver/Job.cpp:31
@@ +30,3 @@
+  // arguments.  Therefore, we need to skip the flag and the next argument.
+  bool Res = llvm::StringSwitch<bool>(Flag)
+    .Cases("-I", "-MF", "-MT", "-MQ", true)
Reid Kleckner wrote:
> Ouch.  Can we get this from Options.td, perhaps in a future change?
Yeah, this is not pretty. Using Options.td sounds like a good idea.


More information about the cfe-commits mailing list