[libcxx] r190563 - A collection of minor type-o fixes. The first two aren't testable, but all tests pass with them. I stumbled across them while experimenting with a std::move that checks its argument for non-const. The third corrects a test that is currently failing.

Howard Hinnant hhinnant at apple.com
Wed Sep 11 17:10:44 PDT 2013


Author: hhinnant
Date: Wed Sep 11 19:10:44 2013
New Revision: 190563

URL: http://llvm.org/viewvc/llvm-project?rev=190563&view=rev
Log:
A collection of minor type-o fixes.  The first two aren't testable, but all tests pass with them.  I stumbled across them while experimenting with a std::move that checks its argument for non-const.  The third corrects a test that is currently failing.

Modified:
    libcxx/trunk/include/map
    libcxx/trunk/include/unordered_map
    libcxx/trunk/test/containers/sequences/forwardlist/forwardlist.cons/size.pass.cpp

Modified: libcxx/trunk/include/map
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/map?rev=190563&r1=190562&r2=190563&view=diff
==============================================================================
--- libcxx/trunk/include/map (original)
+++ libcxx/trunk/include/map Wed Sep 11 19:10:44 2013
@@ -753,7 +753,7 @@ private:
             : __cc(std::forward<_Args>(__args)...) {}
 
         __value_type(const __value_type& __v)
-            : __cc(std::move(__v.__cc)) {}
+            : __cc(__v.__cc) {}
 
         __value_type(__value_type&& __v)
             : __nc(std::move(__v.__nc)) {}

Modified: libcxx/trunk/include/unordered_map
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/unordered_map?rev=190563&r1=190562&r2=190563&view=diff
==============================================================================
--- libcxx/trunk/include/unordered_map (original)
+++ libcxx/trunk/include/unordered_map Wed Sep 11 19:10:44 2013
@@ -641,7 +641,7 @@ private:
             : __cc(std::forward<_Args>(__args)...) {}
 
         __value_type(const __value_type& __v)
-            : __cc(std::move(__v.__cc)) {}
+            : __cc(__v.__cc) {}
 
         __value_type(__value_type&& __v)
             : __nc(std::move(__v.__nc)) {}

Modified: libcxx/trunk/test/containers/sequences/forwardlist/forwardlist.cons/size.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/containers/sequences/forwardlist/forwardlist.cons/size.pass.cpp?rev=190563&r1=190562&r2=190563&view=diff
==============================================================================
--- libcxx/trunk/test/containers/sequences/forwardlist/forwardlist.cons/size.pass.cpp (original)
+++ libcxx/trunk/test/containers/sequences/forwardlist/forwardlist.cons/size.pass.cpp Wed Sep 11 19:10:44 2013
@@ -25,7 +25,7 @@ void check_allocator(unsigned n, Allocat
     typedef std::forward_list<T, Allocator> C;
     C d(n, alloc);
     assert(d.get_allocator() == alloc);
-    assert(std::distance(l.begin(), l.end()) == n);
+    assert(std::distance(d.begin(), d.end()) == n);
 #endif
 }
 





More information about the cfe-commits mailing list