[PATCH] Refactor Compilation::PrintJob and PrintDiagnosticJob into Job::Print
hans at chromium.org
Wed Sep 11 16:54:28 PDT 2013
This moves the code to Job.cpp, which seems like a more natural fit, and replaces the "is this a JobList? is this a Command?" logic with a virtual function call.
It also removes the code duplication between PrintJob and PrintDiagnosticJob and simplifies the code.
There's no functionality change here, except that the Executable is now always printed within quotes, whereas it would previously not be quoted in crash reports, which I think was a bug.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 15402 bytes
Desc: not available
More information about the cfe-commits