[PATCH] Header guard warning is too agressive

Ismail Pazarbasi ismail.pazarbasi at gmail.com
Wed Sep 11 13:15:59 PDT 2013

  Ping! This also fixes PR17053.

Comment at: lib/Lex/PPLexerChange.cpp:280
@@ +279,3 @@
+              << ControllingMacro
+              << FixItHint::CreateReplacement(
+                                              CurPPLexer->MIOpt.GetDefinedLocation(),
I haven't tried thoroughly, but I guess it'd be better to print the fix-it on the warning instead of the note, because clang-check will ignore the note (and I need clang-check to apply the fixit).


More information about the cfe-commits mailing list