[PATCH] Support for modular module-map-files

Doug Gregor dgregor at apple.com
Tue Sep 10 20:20:17 PDT 2013

  LGTM with minor change to diagnostics. This is definitely useful functionality.

Comment at: lib/Lex/ModuleMap.cpp:1310
@@ +1309,3 @@
+  if (!Tok.is(MMToken::StringLiteral)) {
+    Diags.Report(Tok.getLocation(), diag::err_mmap_expected_header) 
+      << "header";
It's a module map file name, not a header name. The diagnostic and comment are wrong.


More information about the cfe-commits mailing list