OpenCL C "long" should always have 64 bits
David.Tweed at arm.com
Mon Sep 9 02:21:26 PDT 2013
Committed (after removing a debugging '#if 1' typo) in 190296. Thanks to Erik for pushing this forward.
From: Erik Schnetter [mailto:schnetter at gmail.com]
Sent: 08 September 2013 19:00
To: Tom Stellard
Cc: Michele Scandale; cfe-commits at cs.uiuc.edu; David Tweed
Subject: Re: OpenCL C "long" should always have 64 bits
On 2013-09-06, at 10:12 , Tom Stellard <tom at stellard.net> wrote:
> On Fri, Sep 06, 2013 at 12:11:48PM +0200, Michele Scandale wrote:
>> On 09/04/2013 05:53 PM, Erik Schnetter wrote:
>>> I do not have commit rights. How do I get this patch committed?
>> I think we have to wait that David or Tom approve this last version and commit it.
>> Maybe a single patch file to apply modification and add tests respect to the
>> last trunk would make easier the commit.
> The latest version of the patch looks good to me, but I agree, the test
> cases should be included in the patch.
Apologies for the delay -- I encountered some code generation problems while testing the patch and wanted to make sure they were not caused by the patch.
(It turns out these problems were caused by using different CPU types while building different object files, leading to different calling conventions. I was surprised that the ABI is not completely determined by the target triple, but that CPU attributes influence this as well... but this is unrelated to the patch here. In my case, 32-byte vectors are passed differently depending on whether AVX instructions are available.)
I recreated the patch with the test cases included; attached below.
Erik Schnetter <schnetter at gmail.com>
My email is as private as my paper mail. I therefore support encrypting
and signing email messages. Get my PGP key from http://pgp.mit.edu/.
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782
More information about the cfe-commits