r190038 - clang-format: Enable formatting of nested blocks.

Tobias Grosser tobias at grosser.es
Fri Sep 6 11:24:41 PDT 2013


On 09/05/2013 02:29 AM, Daniel Jasper wrote:
> Author: djasper
> Date: Thu Sep  5 04:29:45 2013
> New Revision: 190038
>
> URL: http://llvm.org/viewvc/llvm-project?rev=190038&view=rev
> Log:
> clang-format: Enable formatting of nested blocks.
>
> Among other things, this enables (better) formatting lambdas and
> constructs like:
>    MACRO({
>            long_statement();
>            long_statement_2();
>          },
>          {
>            long_statement();
>            long_statement_2();
>          },
>          { short_statement(); }, "");
>
> This fixes llvm.org/PR15381.

Hi Daniel,

this causes the following regression:

Before:

BlockGenerator::BlockGenerator(IRBuilder<> &B, ScopStmt &Stmt, Pass *P)
     : Builder(B), Statement(Stmt), P(P), 
SE(P->getAnalysis<ScalarEvolution>()) {
}

After:

BlockGenerator::BlockGenerator(IRBuilder<> &B, ScopStmt &Stmt, Pass *P)
     : Builder(B), Statement(Stmt), P(P), 
SE(P->getAnalysis<ScalarEvolution>()) {
                                          }

As you can see the closing parenthesis is way too much indented.

Cheers,
Tobias






More information about the cfe-commits mailing list