[PATCH] Test for correct usage of columnWidth in clang fixit hints.

Jordan Rose jordan_rose at apple.com
Fri Sep 6 08:54:42 PDT 2013


I'm not sure. I guess it's fine not to bother.

Jordan


On Sep 5, 2013, at 17:23 , Alexander Kornienko <alexfh at google.com> wrote:

> It's an interesting idea. I'm slightly worried about the need to maintain cross-file consistency though. Is something similar already used in LLVM/clang tests?
> 
> On Sep 6, 2013 2:10 AM, "Jordan Rose" <jordan_rose at apple.com> wrote:
> 
>   Let's drop the CHECK-MACHINE case, but otherwise this looks good.
> 
>   However, if you care about keeping the test files in sync, how about just making this file only contain CHECK lines, and actually compile the original fixit-unicode.c? That allows you to specify the XFAIL properly while avoiding duplication.
> 
> http://llvm-reviews.chandlerc.com/D1607

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130906/c20b7c25/attachment.html>


More information about the cfe-commits mailing list