r189866 - Consumed analysis: update to comments in test cases.

DeLesley Hutchins delesley at google.com
Tue Sep 3 15:35:53 PDT 2013


Author: delesley
Date: Tue Sep  3 17:35:53 2013
New Revision: 189866

URL: http://llvm.org/viewvc/llvm-project?rev=189866&view=rev
Log:
Consumed analysis: update to comments in test cases.
Patch by chris.wailes at gmail.com.

Modified:
    cfe/trunk/test/SemaCXX/warn-consumed-parsing.cpp

Modified: cfe/trunk/test/SemaCXX/warn-consumed-parsing.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-consumed-parsing.cpp?rev=189866&r1=189865&r2=189866&view=diff
==============================================================================
--- cfe/trunk/test/SemaCXX/warn-consumed-parsing.cpp (original)
+++ cfe/trunk/test/SemaCXX/warn-consumed-parsing.cpp Tue Sep  3 17:35:53 2013
@@ -6,8 +6,11 @@
 #define RETURN_TYPESTATE(State)  __attribute__ ((return_typestate(State)))
 #define TESTS_UNCONSUMED         __attribute__ ((tests_unconsumed))
 
-// FIXME: This warning is not generated if it appears bellow the AttrTester0
-//        class declaration.  Why?
+// FIXME: This test is here because the warning is issued by the Consumed
+//        analysis, not SemaDeclAttr.  The analysis won't run after an error
+//        has been issued.  Once the attribute propagation for template
+//        instantiation has been fixed, this can be moved somewhere else and the
+//        definition can be removed.
 int returnTypestateForUnconsumable() RETURN_TYPESTATE(consumed); // expected-warning {{return state set for an unconsumable type 'int'}}
 int returnTypestateForUnconsumable() {
   return 0;





More information about the cfe-commits mailing list