[PATCH] Abstract out the emission of vtables, add basic support for vtable emission when using -cxx-abi microsoft

Reid Kleckner rnk at google.com
Tue Sep 3 11:46:55 PDT 2013



================
Comment at: lib/CodeGen/CGDebugInfo.cpp:1074
@@ +1073,3 @@
+    // FIXME: Add proper support for virtual calls in the Microsoft ABI,
+    // where we may use various vptrs to make a vftable lookup.
+    if (!isa<CXXDestructorDecl>(Method) &&
----------------
Timur Iskhodzhanov wrote:
> Reid Kleckner wrote:
> > The Microsoft ABI doesn't use "various" vptrs, does it?  It just uses a different one?
> A class might have multiple vfptrs and different vcalls might need to use different vfptrs. Can you suggest a better wording?
"multiple vftables"?  Yeah, I realized what you meant and forgot to rewrite my comment. Oops.



http://llvm-reviews.chandlerc.com/D1532



More information about the cfe-commits mailing list