[PATCH] Add more specific lexer flags for misc GNU extensions

Eli Friedman eli.friedman at gmail.com
Thu Aug 29 19:12:50 PDT 2013


On Thu, Aug 29, 2013 at 6:58 PM, Peter N Lewis <peter at stairways.com.au>wrote:

> On 30/08/2013, at 6:34 , Eli Friedman <eli.friedman at gmail.com> wrote:
> > +// RUNNOT: %clang_cc1 -fsyntax-only -verify %s -DZEROARGS
> -Wgnu-zero-variadic-macro-arguments
> > +// RUNNOT: %clang_cc1 -fsyntax-only -verify %s -DIMAGINARYCONST
> -Wgnu-imaginary-constant
> > +// RUNNOT: %clang_cc1 -fsyntax-only -verify %s -DBINARYLITERAL
> -Wgnu-binary-literal
> > +// RUNNOT: %clang_cc1 -fsyntax-only -verify %s -DLINE0
> -Wgnu-zero-line-directive
> >
> > I haven't seen RUNNOT before; is that some sort of new syntax?
>
> They are just disabled RUN statements - disabled by default to cut down on
> excessive invocations of the tests.  If there is a better syntax to
> indicate "you could run this test if you want to, but we wont run it every
> time for everyone", let me know.  I initially tried // DONTRUN: but that
> still runs (I guess the parser looks for RUN:).
>
>
Please don't make it looks like a RUN command if it isn't intended to run.
 You can just make a list with a header like "additional tests" and have a
list of unprefixed commands.


> Any other issues?
>
>

Otherwise, it's fine.

-Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130829/e0373b01/attachment.html>


More information about the cfe-commits mailing list