[PATCH] clang-replace: Afford applying replacements in memory

Manuel Klimek klimek at google.com
Wed Aug 28 08:42:54 PDT 2013


  LG (with nit ;)


================
Comment at: clang-replace/ApplyReplacements.h:85
@@ -82,2 +84,3 @@
 bool applyReplacements(const FileToReplacementsMap &GroupedReplacements,
-                       clang::SourceManager &SM);
+                       clang::Rewriter &DestRewriter);
+
----------------
I'd just call it Rewriter. I think "Dest" is implied in the non-constness.


http://llvm-reviews.chandlerc.com/D1519

BRANCH
  apply-in-mem

ARCANIST PROJECT
  clang-tools-extra



More information about the cfe-commits mailing list