patch: clarify missing template arguments when parsing base specifier

Chandler Carruth chandlerc at google.com
Tue Aug 27 00:54:05 PDT 2013


On Tue, Aug 27, 2013 at 12:49 AM, Nick Lewycky <nlewycky at google.com> wrote:

> Good catch. Foo could be a template function (or a template variable in
> C++14 I suppose) instead of a template class. That I know how to fix.
>

Yikes, hadn't even thought of the cases when it was the wrong kind of
template-id....


> Unfortunately, the template typo correction is wired into
> LookupTemplateName. Even if I bypass isTemplateName and create a
> LookupResult with diagnostics suppressed, we still get the typo
> corrections. I do not know the design of clang well enough to know how to
> change that.
>

Yea, not saying you need to fix, saying it's worth a PR or something to
track. Maybe talk to Kaelyn so its on her or Richard's radar to look at it.
I'm imagining things like 'sorte' -> 'sort' instead of 'sort' -> 'sorter'.
Maybe I'm too worried, but I'd like to make sure we don't lose track of
this issue.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130827/e667d6be/attachment.html>


More information about the cfe-commits mailing list