r189166 - Fix test, make the template type a const pointer.

Robinson, Paul Paul_Robinson at playstation.sony.com
Mon Aug 26 10:02:55 PDT 2013


> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-
> bounces at cs.uiuc.edu] On Behalf Of David Majnemer
> Sent: Saturday, August 24, 2013 2:24 AM
> To: cfe-commits at cs.uiuc.edu
> Subject: r189166 - Fix test, make the template type a const pointer.
> 
> Author: majnemer
> Date: Sat Aug 24 04:24:26 2013
> New Revision: 189166
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=189166&view=rev
> Log:
> Fix test, make the template type a const pointer.

Technically, what you did was make it a pointer-to-const
not a const pointer.  This kind of template parameter always
has to be runtime-constant (e.g. address of global).
(Picky, picky.)

It would still be nice to have more variety in the
non-integral non-type template parameter tests.
--apulr

> 
> Modified:
>     cfe/trunk/test/CodeGenCXX/debug-info-template.cpp
> 
> Modified: cfe/trunk/test/CodeGenCXX/debug-info-template.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/CodeGenCXX/debug-info-
> template.cpp?rev=189166&r1=189165&r2=189166&view=diff
> ========================================================================
> ======
> --- cfe/trunk/test/CodeGenCXX/debug-info-template.cpp (original)
> +++ cfe/trunk/test/CodeGenCXX/debug-info-template.cpp Sat Aug 24
> 04:24:26 2013
> @@ -98,7 +98,7 @@ TC<unsigned, 2, &glb, &foo::e, &foo::f,
>  TC<int, -3, nullptr, nullptr, nullptr, nullptr, tmpl_impl> tcn;
> 
>  struct _GUID;
> -template <_GUID *>
> +template <const _GUID *>
>  struct tmpl_guid {
>  };
> 
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list