[PATCH] clang-replace: Delete change description files

[Edwin Vane]

================
Comment at: clang-replace/tool/ClangReplaceMain.cpp:28
@@ -27,1 +27,3 @@
 
+static cl::opt<bool> RemoveTUReplacementFiles(
+    "remove-change-desc-files",
----------------
Tareq A. Siraj wrote:
> Edwin Vane wrote:
> > I thought the point was to remove files only if everything *was* successfully applied? Default behaviour should be no deletion. A command line switch indicates it's ok to delete files if everything applied cleanly.
> From cpp11-migrate's point of view, if there is a merge conflict, the user fixes the code manually after seeing the report on the console. If we don't delete change description files regardless of success, the user will have to delete these files manually. Is that what we are looking for (thinking about the "lazy typer" case)?
Ok. I've changed my mind but not for the reasons you give here.

================
Comment at: clang-replace/tool/ClangReplaceMain.cpp:36
@@ +35,3 @@
+// "remove-change-desc-files" command line option) when exiting current scope.
+class ScopedFileRemover {
+public:
----------------
Can this RAII tool call a function that's made available through clang-replace's public interface? Also, I'd prefer if you didn't refer to a global variable in this class and simply use its existence as indication that files need to be removed. This will mean only creating this class when the command-line switch is turned on.


http://llvm-reviews.chandlerc.com/D1492

BRANCH
  master

ARCANIST PROJECT
  clang-tools-extra