r189208 - [-cxx-abi microsoft] Unnamed types are mangled less wrong

[David Blaikie]

On Sun, Aug 25, 2013 at 8:02 PM, David Majnemer
<david.majnemer at gmail.com> wrote:
> On Sun, Aug 25, 2013 at 7:59 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> On Sun, Aug 25, 2013 at 7:35 PM, David Majnemer
>> <david.majnemer at gmail.com> wrote:
>> > Author: majnemer
>> > Date: Sun Aug 25 21:35:51 2013
>> > New Revision: 189208
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=189208&view=rev
>> > Log:
>> > [-cxx-abi microsoft] Unnamed types are mangled less wrong
>>
>> Test case?
>
>
> <unnamed-tag> is still wrong, <unnamed-tag>@ is just marginally less wrong.
> I thought of this change more of a code cleanup than a bug-fix for mangling.

A change in behavior really ought to have a test. If it's still wrong,
a FIXME showing the ring mangling in the test case should suffice.

The fact that this didn't break any existing tests seems to indicate
that this area lacks coverage - adding tests now, even if they
demonstrate the broken behavior & document what it should be, might be
nice, so we can track progress towards correctness.

>
>>
>>
>> >
>> > Modified:
>> >     cfe/trunk/lib/AST/MicrosoftMangle.cpp
>> >
>> > Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/MicrosoftMangle.cpp?rev=189208&r1=189207&r2=189208&view=diff
>> >
>> > ==============================================================================
>> > --- cfe/trunk/lib/AST/MicrosoftMangle.cpp (original)
>> > +++ cfe/trunk/lib/AST/MicrosoftMangle.cpp Sun Aug 25 21:35:51 2013
>> > @@ -508,8 +508,8 @@ MicrosoftCXXNameMangler::mangleUnqualifi
>> >        }
>> >
>> >        // When VC encounters an anonymous type with no tag and no
>> > typedef,
>> > -      // it literally emits '<unnamed-tag>'.
>> > -      Out << "<unnamed-tag>";
>> > +      // it literally emits '<unnamed-tag>@'.
>> > +      Out << "<unnamed-tag>@";
>> >        break;
>> >      }
>> >
>> >
>> >
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>