[PATCH] Comment fix for RecursiveASTVisitor
fragmentshaders at gmail.com
Sat Aug 24 18:34:11 PDT 2013
Thanks. Commit in r189185.
On Sat, Aug 24, 2013 at 12:51 PM, James Dennett <jdennett at googlers.com>wrote:
> On Sat, Aug 24, 2013 at 11:07 AM, Michael Han <fragmentshaders at gmail.com>
> > The example in the comment has this node visiting order: VisitDecl(),
> > VisitNamedDecl(), VisitNamespaceDecl(), so the type of the given node
> > be NamespaceDecl, not NamedDecl. OK to commit?
> This looks like it qualifies as trivial/obvious, so yes please. (If
> you want an OK from an approver, that's not me--but I'd be comfortable
> to commit this comment fix without more formal approval.)
> -- James
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits