[PATCH] Fix r188763 - CLANG_ORDER_FILE defined as a BOOL instead as a STRING

Jordan Rose jordan_rose at apple.com
Fri Aug 23 16:36:28 PDT 2013

Actually, it should be a FILEPATH, shouldn't it?

On Aug 23, 2013, at 16:00 , Edoardo P. <ed0.88.prez at gmail.com> wrote:

> Hi,
> I noticed that in tools/clang/CMakeLists.txt CLANG_ORDER_FILE was added, but it was defined with the cmake function 'option', which makes the variable a BOOL, which is wrong. I noticed it when I got: 'error: cannot open ON: No such file or directory' when linking clang executable. This happened because I accidentally checked the 'option' CLANG_ORDER_FILE with cmake-gui. Since it is a filename, it should be defined as a STRING with 'set'. The attached patch should fix this.
> Regards,
> Edward-san
> -- 
> Mathematics is the language with which God has written the universe. (Galilei)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake_clang_order_file_fix.diff
Type: application/octet-stream
Size: 485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130823/6cde4d10/attachment.obj>
-------------- next part --------------
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list