[PATCH] clang-replace: Delete change description files

Stefanus Du Toit stefanus.du.toit at intel.com
Fri Aug 23 11:51:57 PDT 2013

Comment at: clang-replace/tool/ClangReplaceMain.cpp:80
@@ -53,3 +79,3 @@
   if (!applyReplacements(GroupedReplacements, SM))
     return 1;
Stefanus Du Toit wrote:
> And likewise for this. Seems to me they should only be removed if all of the operations succeeded. As a bonus, then you don't need ScopedFileRemover anymore!
Actually, I guess I can see why you might want this behaviour (removing even if errors occurred) for something like cpp11-migrate. But I now _especially_ think this should be a command-line option.


More information about the cfe-commits mailing list