[patch] libcxx src win32

[Reid Kleckner]

Looks fine to me from a functionality POV.  Howard may want to adjust the
formatting as he likes.  There are tabs in the support.cpp portion of the
patch.

     va_list ap;
     va_start(ap, format);
     int result;
-#ifndef _LIBCPP_NO_EXCEPTIONS
-    try {
-#endif
-        result = vasprintf(sptr, format, ap);
-#ifndef _LIBCPP_NO_EXCEPTIONS
-    } catch( ... ) {
-        va_end(ap);
-        throw;
-    }
-#endif
+    result = vasprintf(sptr, format, ap);
     va_end(ap);
     return result;
 }

Is the idea here that vsprintf calls no C++ functions which can throw, just
malloc, or that this cleanup isn't necessary at all?



On Thu, Aug 22, 2013 at 5:18 PM, G M <gmisocpp at gmail.com> wrote:

> Hello Everyone, in particular Reid.
>
> This patch is a subset of a previous patch I sent. You asked to
> separate that patch out to make it easier for you to review.
>
> This is the non contentious part of that patch which you described as
> "obvious goodness".
>
> I'll resubmit the other patch once this one is approved which will then be
> smaller and easier to review without the attached patch being part of it.
>
> It'll also be easier for me to create that next patch without having to
> work around this part in my tree.
>
> Thanks
> Glen
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130822/0c1cba0d/attachment.html>