r189055 - DataFlowSanitizer: Add a design doc paragraph on checking ABI consistency.

Peter Collingbourne peter at pcc.me.uk
Thu Aug 22 13:08:20 PDT 2013


Author: pcc
Date: Thu Aug 22 15:08:20 2013
New Revision: 189055

URL: http://llvm.org/viewvc/llvm-project?rev=189055&view=rev
Log:
DataFlowSanitizer: Add a design doc paragraph on checking ABI consistency.

Differential Revision: http://llvm-reviews.chandlerc.com/D1443

Modified:
    cfe/trunk/docs/DataFlowSanitizerDesign.rst

Modified: cfe/trunk/docs/DataFlowSanitizerDesign.rst
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/DataFlowSanitizerDesign.rst?rev=189055&r1=189054&r2=189055&view=diff
==============================================================================
--- cfe/trunk/docs/DataFlowSanitizerDesign.rst (original)
+++ cfe/trunk/docs/DataFlowSanitizerDesign.rst Thu Aug 22 15:08:20 2013
@@ -205,3 +205,16 @@ native ABI function directly and the pas
 internally.  This has the advantage of reducing the number of union operations
 required when the return value label is known to be zero (i.e. ``discard``
 functions, or ``functional`` functions with known unlabelled arguments).
+
+Checking ABI Consistency
+------------------------
+
+DFSan changes the ABI of each function in the module.  This makes it possible
+for a function with the native ABI to be called with the instrumented ABI,
+or vice versa, thus possibly invoking undefined behavior.  A simple way
+of statically detecting instances of this problem is to prepend the prefix
+"dfs$" to the name of each instrumented-ABI function.
+
+This will not catch every such problem; in particular function pointers passed
+across the instrumented-native barrier cannot be used on the other side.
+These problems could potentially be caught dynamically.





More information about the cfe-commits mailing list