r189003 - Revert "Remove some unused variables identified by Juergen Ributzka *I need to turn on this warning in Visual C++ - sorry!*"

[Manuel Klimek]

On Thu, Aug 22, 2013 at 3:15 PM, David Blaikie <dblaikie at gmail.com> wrote:

>
> On Aug 22, 2013 5:16 AM, "Manuel Klimek" <klimek at google.com> wrote:
> >
> > Author: klimek
> > Date: Thu Aug 22 07:12:05 2013
> > New Revision: 189003
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=189003&view=rev
> > Log:
> > Revert "Remove some unused variables identified by Juergen Ributzka *I
> need to turn on this warning in Visual C++ - sorry!*"
> >
> > This reverts commit d01d0b63d87ac465f15ce1d6b56bf3faf4525769.
>
> We have a script (llvm/until/git-svn/git-svnrevert) that will do a git
> revert of a bit commit hash, but make the commit message include the svn
> revision instead. This makes non-git users happy.
>
> (Also I personally find it helpful to have the reason for revert in the
> revert commit message, or at least some short summary thereof)
>

Ah, sorry, I had that in but messed up my rebase -i state...


> >
> > Modified:
> >     cfe/trunk/lib/Parse/ParseExprCXX.cpp
> >     cfe/trunk/lib/Sema/SemaLambda.cpp
> >
> > Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseExprCXX.cpp?rev=189003&r1=189002&r2=189003&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/lib/Parse/ParseExprCXX.cpp (original)
> > +++ cfe/trunk/lib/Parse/ParseExprCXX.cpp Thu Aug 22 07:12:05 2013
> > @@ -938,6 +938,7 @@ ExprResult Parser::ParseLambdaExpression
> >
> >
> >      if (Tok.isNot(tok::r_paren)) {
> > +      sema::LambdaScopeInfo *LSI = Actions.getCurLambda();
> >        if (getLangOpts().CPlusPlus1y)
> >
>  Actions.RecordParsingTemplateParameterDepth(TemplateParameterDepth);
> >        ParseParameterDeclarationClause(D, Attr, ParamInfo, EllipsisLoc);
> >
> > Modified: cfe/trunk/lib/Sema/SemaLambda.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaLambda.cpp?rev=189003&r1=189002&r2=189003&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/lib/Sema/SemaLambda.cpp (original)
> > +++ cfe/trunk/lib/Sema/SemaLambda.cpp Thu Aug 22 07:12:05 2013
> > @@ -143,6 +143,7 @@ ParmVarDecl *Sema::ActOnLambdaAutoParame
> >        AutoParameterPosition,  // our template param index
> >        /* Identifier*/ 0, false, PVD->isParameterPack());
> >    LSI->AutoTemplateParams.push_back(TemplateParam);
> > +  QualType AutoTy = PVD->getType();
> >    // Now replace the 'auto' in the function parameter with this invented
> >    // template type parameter.
> >    QualType TemplParamType = QualType(TemplateParam->getTypeForDecl(),
> 0);
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130822/e0ac186c/attachment.html>