r188663 - XCore target: correct test layout

Robert Lytton robert at xmos.com
Thu Aug 22 02:10:34 PDT 2013

I'm glad you asked - I got a positive result the first time...
But your question coincided with my machine grinding to a halt.
After a reboot and rebuild of code base - no it doesn't pass.
I needed to include the flags added by the driver viz: "-fno-signed-char -fno-common"
(these are tested for in test/Driver/xcore-opts.c)

However, "-triple xcore" is fine... but I have changed it to "-triple xcore-unknown-unknown" for consistency.

-// RUN: %clang -target xcore -O0 -o - -emit-llvm -S %s | FileCheck %s
+// RUN: %clang_cc1 -triple xcore-unknown-unknown -fno-signed-char -fno-common -emit-llvm -o - %s | FileCheck %s

Thank you


From: Dmitri Gribenko [gribozavr at gmail.com]
Sent: 22 August 2013 09:09
To: Robert Lytton
Cc: cfe-commits cfe
Subject: Re: r188663 - XCore target: correct test layout

On Thu, Aug 22, 2013 at 1:01 AM, Robert Lytton <robert at xmos.com> wrote:
> Hi Dmitri,
> Here is a patch to correct test RUN parameters.

Does it pass tests?  (I did not try.)  The -triple does not look like
a triple (for example, x86_64-unknown-unknown).  Should it be


(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PatchTestRunParams
Type: application/octet-stream
Size: 758 bytes
Desc: PatchTestRunParams
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130822/59b315c0/attachment.obj>

More information about the cfe-commits mailing list