[PATCH] Add more specific lexer flags for misc GNU extensions

Peter N Lewis peter at stairways.com.au
Wed Aug 21 19:03:46 PDT 2013

On 22/08/2013, at 2:25 , Eli Friedman <eli.friedman at gmail.com> wrote:

> On Wed, Aug 21, 2013 at 6:10 AM, Peter N Lewis <peter at stairways.com.au> wrote:
> Here is batch two of the specific gnu flags.  This patch adds the following flags:
> -Wgnu-zero-variadic-macro-arguments
> -Wgnu-token-pasting-comma
> These two are actually very closely related (the latter doesn't make sense without the former).  We might want to consider putting them under the same flag.

I agree, and thought the same myself.  Perhaps -Wgnu-variadic-macro to cover both?  The "gnu" already implies it is a gnu extension, so -Wgnu-variadic-macro-extension would be redundant.  But if we get to the point where we want to claim it as a "legitimate" extennsion, then -Wvariadic-macro would not work as an alternative, where -Wzero-variadic-macro-arguments and -Wtoken-pasting-comma do.

>  -Wgnu-imaginary-constant
> -Wgnu-binary-literal
> -Wgnu-line-zero-directive
> This name is sort of confusing; it isn't really a "line-zero" directive.

Suggestions for an alternative?  The error message (currently) is "#line directive with zero argument is a GNU extension" and happens when you have 

#line 0

I wasn't sure -Wgnu-line-0-directive was a good idea.  Any other ideas?  Let me know and I'll redo the patch.

Keyboard Maestro 6.2 now out - control Mail, reveal a file, format AppleScripts and more.

Keyboard Maestro <http://www.keyboardmaestro.com/> Macros for your Mac
<http://www.stairways.com/>           <http://download.keyboardmaestro.com/>

More information about the cfe-commits mailing list