[PATCH] cpp11-migrate: Add a class to support include directives modifications (Windows bot fix)

Edwin Vane edwin.vane at intel.com
Wed Aug 21 08:50:55 PDT 2013



================
Comment at: unittests/cpp11-migrate/IncludeDirectivesTest.cpp:25
@@ +24,3 @@
+  llvm::error_code EC = llvm::sys::fs::current_path(CurrentDir);
+  assert(!EC);
+  (void)EC;
----------------
Instead of using assertions, how about using `ASSERT_*` and then wrapping calls to `applyActionOnCode` with `ASSERT_NO_FATAL_ERROR()`. This is in keeping with the semantics of this function anyway: it should not fail.


http://llvm-reviews.chandlerc.com/D1438

BRANCH
  include-directives

ARCANIST PROJECT
  clang-tools-extra



More information about the cfe-commits mailing list