[Patch] Fix for incorrect ABI in case we have an unused union argument passed by value

Karthik Bhat blitz.opensource at gmail.com
Wed Aug 21 02:31:48 PDT 2013

Hi John,
Thanks for the reply. Please correct me if i'm wrong but shouldn't this be
general for all unions and not just transparent unions?
Shouldn't we be handling union in similar way we are handling structures in
this function except that the size of union will be calculated differently?

On Wed, Aug 21, 2013 at 3:20 AM, John McCall <rjmccall at apple.com> wrote:

> On Aug 20, 2013, at 6:11 AM, Karthik Bhat <blitz.opensource at gmail.com>
> wrote:
> > Please find the patch for incorrect ABI in case we have a union argument
> passed by value.
> At the very least, you need to be checking for just transparent unions
> instead of applying this logic uniformly to all unions.
> John.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130821/dec430c8/attachment.html>

More information about the cfe-commits mailing list