[PATCH] Refactor VariantMatcher to use a tagged union.

[Manuel Klimek]

================
Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:81
@@ -80,4 +80,3 @@
 
-  /// \brief Determines if any of the contained matchers can be converted
-  ///   to \c Matcher<T>.
+  /// \brief Determines the contained matcher can be converted to \c Matcher<T>.
   ///
----------------
insert if or whether?

================
Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:140
@@ +139,3 @@
+  };
+  union {
+    SingleRep *AsSingle;
----------------
Any reason not to use an interface with two implementations? This smells a lot like building our own inheritance implementation ...


http://llvm-reviews.chandlerc.com/D1446