patch: fixit for characters with invalid source encoding

Nick Lewycky nlewycky at google.com
Tue Aug 20 21:14:41 PDT 2013


On 20 August 2013 20:35, Eli Friedman <eli.friedman at gmail.com> wrote:

> On Tue, Aug 20, 2013 at 8:08 PM, Nick Lewycky <nlewycky at google.com> wrote:
>
>> The attached patch adds a fixit for invalid characters to replace them
>> with the equivalent \xNN code. Please review!
>>
>
> You might want to put a warning on top of the test that this file isn't
> valid UTF-8, despite appearing to be a text file.
>

Good idea. Done, r188863.

Otherwise, looks good; nice idea!
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130820/bdc758f2/attachment.html>


More information about the cfe-commits mailing list