[PATCH] AST: __uuidof should leak through templated types

Reid Kleckner rnk at google.com
Tue Aug 20 17:10:10 PDT 2013


  LGTM


================
Comment at: lib/AST/ExprCXX.cpp:113
@@ -76,2 +112,3 @@
   StringRef Uuid;
+  bool HasMultipleGUIDs = false;
   if (isTypeOperand())
----------------
The caller doesn't seem to need this, so I'd make the outparam optional and point it at a local boolean whenever it isn't provided.

================
Comment at: test/Parser/MicrosoftExtensions.cpp:124
@@ +123,3 @@
+struct empty {};
+struct inher : public thing<empty, uuid2> {};
+
----------------
Can I get uuidof inher by itself?


http://llvm-reviews.chandlerc.com/D1419



More information about the cfe-commits mailing list