r188663 - XCore target: correct test layout

[Robert Lytton]

Hi Dmitri,

No reason, apart from ignorance.

I've searched briefly for documentation, but did not come across anything that explains the mechanism.
Could you enlighten me?
Is 'clang' the driver, which in turn will call the C compiler 'cc1' (assuming a .c file)?
As we know we want the C compiler we can call it directly - removing an unnecessary step.
Does the test suite will convert 'clang_cc1' into 'clang -cc1'?

Also, would I be right in thinking that -O0 will be the default, so this can be left off too?

Thus, I should use:
    // RUN: %clang_cc1 -target xcore -o - -emit-llvm -S %s | FileCheck %s

However, the driver test should remain:
    // RUN: %clang -target xcore %s -### -o %t.o 2>&1 FileCheck %s

I'll await your reply before making changes.
Thank you

Robert
________________________________________
From: Dmitri Gribenko [gribozavr at gmail.com]
Sent: 19 August 2013 17:22
To: Robert Lytton
Cc: cfe-commits cfe
Subject: Re: r188663 - XCore target: correct test layout

On Mon, Aug 19, 2013 at 2:46 AM, Robert Lytton <robert at xmos.com> wrote:
> Author: rlytton
> Date: Mon Aug 19 04:46:32 2013
> New Revision: 188663
>
> URL: http://llvm.org/viewvc/llvm-project?rev=188663&view=rev
> Log:
> XCore target: correct test layout
>
> Modified:
>     cfe/trunk/test/CodeGen/xcore-abi.c
>     cfe/trunk/test/Driver/xcore-opts.c
>
> Modified: cfe/trunk/test/CodeGen/xcore-abi.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/xcore-abi.c?rev=188663&r1=188662&r2=188663&view=diff
> ==============================================================================
> --- cfe/trunk/test/CodeGen/xcore-abi.c (original)
> +++ cfe/trunk/test/CodeGen/xcore-abi.c Mon Aug 19 04:46:32 2013
> @@ -1,8 +1,13 @@
> -// RUN: %clang -target xcore -O1 -o - -emit-llvm -S %s | FileCheck %s
> +// RUN: %clang -target xcore -O0 -o - -emit-llvm -S %s | FileCheck %s

Why not %clang_cc1?

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/