libcxx cmakelists.txt

[Reid Kleckner]

I updated my cmake binary and confirmed that this fixes the warning, so
feel free to apply.  It's not obvious to me why the semicolon is necessary
to force this to be a list.


On Mon, Aug 19, 2013 at 12:13 PM, Howard Hinnant <hhinnant at apple.com> wrote:

>
> On Aug 15, 2013, at 9:21 PM, G M <gmisocpp at gmail.com> wrote:
>
> > This is not important, but when I build libcxx using a recent beta
> version cmake,
> > namely this one "cmake version 2.8.11.20130809-gba97e"
> >
> > I get this error now:
> >
> > CMake Warning (dev) in CMakeLists.txt:
> >   Syntax Warning in cmake code at
> >     c:/libcxx/CMakeLists.txt:48:54
> >
> >   Argument not separated from preceding token by whitespace.
> > This warning is for project developers.  Use -Wno-dev to suppress it.
> >
> > The offending line 48 appears to be this:
> >
> > set_property(CACHE LIBCXX_CXX_ABI PROPERTY STRINGS "";${CXXABIS})
> >
> > Removing the quotes and changing the line to the line below fixes the
> warning and I hope does not change the meaning?
> > I've yet to observe any harm from the change on my build at least.
> >
> > set_property(CACHE LIBCXX_CXX_ABI PROPERTY STRINGS ;${CXXABIS})
> >
> > This is all the attached patch does.
> >
> > The ; is curious as to why it's needed but I do remember a problem
> vaguely that I fixed in this file some time ago related to ; delimiters and
> maybe CXXABIS that suggests it is necessary so I've left the ;
> >
> > I mention that in case it allows anyone to recall the conversation that
> will allow them to remove the ";" too. But otherwise they probably
> shouldn't.
> > As long as "";$(X) yields the same string as ;$(x) it should be a safe
> change. Hopefully a regular cmake user can verify this.
> >
> > It's not a necessary fix it just removes an irritant warning that can be
> supressed with a flag anyway.
> >
> >
> > <cmakelists.diff>_______________________________________________
>
> I no nothing about cmake.  I have seen no comments about this patch.  If
> there are none, I'll go ahead and commit it.
>
> Howard
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130819/038f9fdf/attachment.html>