XCore make test checks more concise

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Aug 16 16:41:48 PDT 2013


LGTM

On 16 August 2013 04:36, Robert Lytton <robert at xmos.com> wrote:
> Hi Rafael,
>
> Here is the amended patch.
> I've moved IL checks into test/CodeGen/xcore-abi.c.
> Also built at -O0, amending CHECK statements to be less brittle.
>
> Robert
>
> ________________________________________
> From: Rafael EspĂ­ndola [rafael.espindola at gmail.com]
> Sent: 16 August 2013 00:53
> To: Robert Lytton
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: XCore make test checks more concise
>
> On 15 August 2013 11:29, Robert Lytton <robert at xmos.com> wrote:
>> (http://clang.llvm.org/docs/DriverInternals.html)
>> Now I get it!
>>
>> So test should be:
>> // RUN: %clang -target xcore %s -### -o %t.o 2>&1 | FileCheck  %s
>> // CHECK: "-momit-leaf-frame-pointer"
>> // CHECK: "-fno-signed-char"
>> // CHECK: "-fno-common"
>
> Yes.
>
>> I'm a bit bothered that there is no "-fomit-frame-pointer".
>> Should I see this too?
>
> It is mdisable-fp-elim in the cc1 level.
>
> Cheers,
> Rafael




More information about the cfe-commits mailing list